Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/about caselaw page update #725

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

Terry-Price
Copy link
Contributor

  • Made changes and additions to the footer
  • Created a 'Privacy Notice' page – not linked from footer yet as it needs Director level sign off, but when it is, it will sit in leagl column under the Cookies link.
  • Made wholesale changes to the 'What to expect page' and renamed it 'About this service'.
  • Took link out of page header and moved it to the footer under 'About' column.

Changes in this PR:

Trello card / Rollbar error (etc)

https://trello.com/c/OYVqgxKh/748-fcl-policies-all-ducks-in-a-row-%F0%9F%A6%86

Screenshots of UI changes:

Before

After

  • Requires env variable(s) to be updated

Copy link
Contributor

@timcowlishaw timcowlishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just had to make a fair few changes to this myself as a result of rebasing on master, so will defer to @jacksonj04 @anthonyhashemi or @dragon-dxw for explicit approval!

@codecov-commenter
Copy link

Codecov Report

Merging #725 (8548d4a) into main (3cf9322) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          25       25           
  Lines        1102     1102           
  Branches       55       55           
=======================================
  Hits         1016     1016           
  Misses         72       72           
  Partials       14       14           
Impacted Files Coverage Δ
judgments/tests/tests.py 96.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jacksonj04 jacksonj04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as far as the code goes. I can't speak to the substance of the text, but nothing looks obviously wrong.

@jacksonj04 jacksonj04 added this pull request to the merge queue May 25, 2023
@jacksonj04 jacksonj04 merged commit 228d135 into main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants