Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: table - cellFormatter property is not called when the cell does not contain a value #1465

Closed
SuperITMan opened this issue Dec 16, 2019 · 0 comments · Fixed by #1468
Closed

ui: table - cellFormatter property is not called when the cell does not contain a value #1465

SuperITMan opened this issue Dec 16, 2019 · 0 comments · Fixed by #1468
Labels
comp: stark-ui type: bug
Projects
10.0.0-rc.3
Milestone
10.0.0-rc.3

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

In Stark Table, when a cell has no value, the cellFormatter property, optionally, defined for the column is not triggered.

That means the developer cannot set a default value with cellFormatter in case there is no value.

Expected behavior

The cellFormatter property should be used even if there is no value for the cell.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Bug fixing

Environment


Angular version: 7.x
Stark version: 10.0.0-rc.2
@SuperITMan SuperITMan added this to the 10.0.0-rc.3 milestone Dec 16, 2019
@SuperITMan SuperITMan added this to To do in 10.0.0-rc.3 via automation Dec 16, 2019
SuperITMan referenced this issue in SuperITMan/stark Dec 17, 2019
@SuperITMan
fix(stark-ui): fixed column issue when rawValue is undefined, cellFor…
cae23cb 
…matter is not called

ISSUES CLOSED: #1465
@SuperITMan SuperITMan self-assigned this Dec 17, 2019
SuperITMan referenced this issue in SuperITMan/stark Dec 18, 2019
@SuperITMan
fix(stark-ui): fixed column issue with cellFormatter which is not cal…
82f0b6f 
…led when the rawValue is undefined

ISSUES CLOSED: #1465
@SuperITMan SuperITMan mentioned this issue Dec 18, 2019
Merged
3 tasks
SuperITMan referenced this issue in SuperITMan/stark Dec 18, 2019
@SuperITMan
fix(stark-ui): fixed column issue when rawValue is undefined, cellFor…
397bec8 
…matter is not called

ISSUES CLOSED: #1465
SuperITMan referenced this issue in SuperITMan/stark Jan 6, 2020
@SuperITMan
fix(stark-ui): fixed column issue when rawValue is undefined, cellFor…
815ac6c 
…matter is not called

ISSUES CLOSED: #1465
10.0.0-rc.3 automation moved this from To do to Done Jan 7, 2020
SuperITMan referenced this issue in SuperITMan/stark Jan 8, 2020
@SuperITMan
fix(stark-ui): fixed column issue when rawValue is undefined, cellFor…
5a6a883 
…matter is not called

ISSUES CLOSED: #1465
@SuperITMan SuperITMan removed their assignment Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
No open projects
10.0.0-rc.3
  
Done
Milestone
10.0.0-rc.3
Development

Successfully merging a pull request may close this issue.

fix(stark-ui): cellFormatter is now called even when the rawValue is undefined SuperITMan/stark
1 participant
@SuperITMan