Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase: latest version 10.0.0-rc.3 not published on ghPages #1485

Closed
christophercr opened this issue Jan 14, 2020 · 0 comments · Fixed by #1548
Closed

showcase: latest version 10.0.0-rc.3 not published on ghPages #1485

christophercr opened this issue Jan 14, 2020 · 0 comments · Fixed by #1548

Comments

@christophercr
Copy link
Collaborator

christophercr commented Jan 14, 2020

I'm submitting a...


[X] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Due to a wrong EXPECTED_NODE_VERSION variable in the gh-deploy.sh script, the latest version of the Showcase and the API docs was not published to ghPages during the last release:

Publishing docs to GH pages
=============================================
Skipping release because this is not the expected version of node: 10

Expected behavior

The latest version of the Showcase and the API Docs should be published to ghPages and available in https://stark.nbb.be

Minimal reproduction of the problem with instructions

Check these urls were the version 10.0.0-rc.3 is missing:

https://github.com/NationalBankBelgium/stark/tree/gh-pages/showcase
https://github.com/NationalBankBelgium/stark/tree/gh-pages/api-docs/stark-core

Environment


Stark version: 10.0.0-rc.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant