Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build-main): changed expected node version to 10 in gh-deploy script #1548

Merged

Conversation

SuperITMan
Copy link
Member

ISSUES CLOSED: #1485

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The node_version expected by the "gh-deploy.sh" script is 8.
We forgot to change the expected node version when we removed support for Node 8 in #1447

Issue Number: #1485

What is the new behavior?

The expected node_version is 10.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added this to the 10.0.0-rc.4 milestone Jan 19, 2020
@SuperITMan SuperITMan added this to In progress in 10.0.0-rc.4 via automation Jan 19, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.068% when pulling ce3819b on SuperITMan:bugfix/fix-ghpages-deploy into 56b84f8 on NationalBankBelgium:master.

10.0.0-rc.4 automation moved this from In progress to Reviewer approved Jan 20, 2020
Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@nicanac nicanac merged commit 4ff8b7e into NationalBankBelgium:master Jan 20, 2020
10.0.0-rc.4 automation moved this from Reviewer approved to Done Jan 20, 2020
@SuperITMan SuperITMan deleted the bugfix/fix-ghpages-deploy branch January 20, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
10.0.0-rc.4
  
Done
Development

Successfully merging this pull request may close these issues.

showcase: latest version 10.0.0-rc.3 not published on ghPages
3 participants