-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: implement partial AppConfig validations depending on its usage by Stark services #382
Labels
Milestone
Comments
christophercr
added
P1
must
comp: stark-all
To apply for all Stark modules
type: enhancement
labels
May 18, 2018
christophercr
referenced
this issue
in christophercr/stark
May 22, 2018
christophercr
referenced
this issue
in christophercr/stark
May 23, 2018
christophercr
changed the title
all: implement APP_INITIALIZER for Stark services where some initialization logic is needed
all: implement partial AppConfig validations depending on its usage by Stark services
May 23, 2018
3 tasks
christophercr
referenced
this issue
in christophercr/stark
May 23, 2018
christophercr
referenced
this issue
in christophercr/stark
May 23, 2018
christophercr
referenced
this issue
in christophercr/stark
May 23, 2018
christophercr
referenced
this issue
in christophercr/stark
May 23, 2018
christophercr
referenced
this issue
in christophercr/stark
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a...
Current behavior
Some services in the different Stark modules need the AppConfig entity to be provided but this is not ensured by any means.
Expected behavior
Some logic in the service constructor should ensure that the injected AppConfig for the different services is present and valid before such services are initiliazed.
What is the motivation / use case for changing the behavior?
Due to the modularity we want to achieve in Stark, every module should take care of validating the piece of the AppConfig it cares about.
The text was updated successfully, but these errors were encountered: