Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: implement partial AppConfig validations depending on its usage by Stark services #382

Closed
christophercr opened this issue May 18, 2018 · 0 comments · Fixed by #383
Closed
Labels

Comments

@christophercr
Copy link
Collaborator

christophercr commented May 18, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Some services in the different Stark modules need the AppConfig entity to be provided but this is not ensured by any means.

Expected behavior

Some logic in the service constructor should ensure that the injected AppConfig for the different services is present and valid before such services are initiliazed.

What is the motivation / use case for changing the behavior?

Due to the modularity we want to achieve in Stark, every module should take care of validating the piece of the AppConfig it cares about.

@christophercr christophercr self-assigned this May 18, 2018
@dsebastien dsebastien added this to the 10.0.0-alpha.3 milestone May 18, 2018
@christophercr christophercr changed the title all: implement APP_INITIALIZER for Stark services where some initialization logic is needed all: implement partial AppConfig validations depending on its usage by Stark services May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants