This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
--counter: accept colon character (useful for time-tracking apps with hour:min) #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify regexp to track hour counters such as `(1:23)`.
|
I noticed |
|
@trkoch context/screenshot, please. How does this end up displaying in your dock? It supports and correctly displays the colon? |
Yes.
|
ronjouch
changed the title
|
@trkoch merged, thanks! Will ship in the next release, in a few days/weeks. |
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
… hour:min in title (PR nativefier#1378) Modify regexp to track hour counters such as `(1:23)`. This is supported by macOS' dock and displays in the red badge: https://user-images.githubusercontent.com/73974/162786478-609a90e1-5efb-44ba-9aa5-7a3038f0689b.png
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify regexp to track hour counters such as
(1:23).