Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Fixes the issue with "/"'s in the page title #24

Merged
merged 1 commit into from
Jan 21, 2016
Merged

Fixes the issue with "/"'s in the page title #24

merged 1 commit into from
Jan 21, 2016

Conversation

himynameisdave
Copy link

This commit resolves an bug where the page title would cause a filepaths
issue due to it having a forward slash.

The code committed here uses a simple regular expression to find all
instances of forward slashes in the page title and replace them with an
empty string.

Resolves #22

For more on this, please see:
#22

This commit resolves an bug where the page title would cause a filepaths
issue due to it having a forward slash.

The code committed here uses a simple regular expression to find all
instances of forward slashes in the page title and replace them with an
empty string.

Resolves #22

For more on this, please see:
#22
jiahaog added a commit that referenced this pull request Jan 21, 2016
Fixes the issue with "/"'s in the page title
@jiahaog jiahaog merged commit 6738512 into nativefier:master Jan 21, 2016
@jiahaog
Copy link
Member

jiahaog commented Jan 21, 2016

Thanks for the quick fix!

@himynameisdave
Copy link
Author

@jiahaog No problem this tool is amazing!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ bug ] fails if there is a '/' in the application/page title
2 participants