This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Document internal-urls option #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update readme to include documentation on `internal-urls` option
ronjouch
suggested changes
Oct 22, 2017
docs/api.md
Outdated
| ``` | ||
| --internal-urls <regex> | ||
| ``` | ||
| Customize what should open in an external browser. If the URL does not match the regex, it will open in an external browser. |
There was a problem hiding this comment.
@cbess awwwesome, thanks for noticing this missing piece 👍. Users taught us --internal-urls has several interesting use cases, could you document them too using my comment at #212 (comment) ? Feel free to clarify / reformulate as needed 🙂.
There was a problem hiding this comment.
No prob. Will do. Thanks for the great tool.
There was a problem hiding this comment.
I think I made the changes you mentioned.
|
Let me know if you'd like any further changes. |
ronjouch
approved these changes
Feb 6, 2018
|
Awesome, thanks @cbess ! |
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme to include documentation on
internal-urlsoption