This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Add --browserwindow-options to completely expose Electron options #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: if `_log` is renamed to `log` without underscore, e2e fails
|
@FabulousCupcake thanks! Merging. |
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…ativefier#835) This adds a new flag `--browserwindow-options`, taking a stringified JSON object as input. It will be inserted directly into the options when BrowserConfig is initialized. This allows total configurability of the electron BrowserWindow configuration via nativefier. An example use case is added to the documentation, which modifies the default font family in the browser. #### References - https://github.com/electron/electron/blob/master/docs/api/browser-window.md#new-browserwindowoptions - See the following for electron v3.1.7 - https://github.com/electron/electron/blob/v3.1.7/docs/api/browser-window.md#new-browserwindowoptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to the CLI (
--browserwindow-options), taking a stringified JSON object as input.It will be inserted directly into the options when BrowserConfig is initialised in
/app/src/components/mainWindow/mainWindow.js.This allows total configurability of the electron BrowserWindow configuration via
nativefier.An example use case is added to the documentation, which modifies the default font family in the browser.
References