fix iOS connection to loopback address (127.0.0.1) and sourceMapPathOverrides for all file extensions #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vallemar
changed the title
|
I think this PR is ready for review! |
vallemar
changed the title
vallemar
changed the title
|
@vallemar the repo is now part of community. Would you like to become a maintainer of this plugin? |
|
@farfromrefug Yeah! |
|
@vallemar awesome then you officially are! |
|
Hail to the savior @vallemar 👑! |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS it never worked because by not specifying the address the address 127.0.0.1 was used and the websocket server rejected the connection.
In Android it is just the opposite, it rejects the localhost connection and accepts 127.0.0.1 so it has been handled to establish the address that will then be used by the
NativeScriptTargetDiscoveryclass.Also added logic to add sourceMapPathOverrides for files
["js", "ts", "vue", "svelte", "jsx", "tsx"]since they didn't seem to work and breakpoints didn't work they worked. Now this propertydevtoolNamespaceis not necessary since the name of the package.json.name is searched and added to sourceMapPathOverrides, but it has also been added the logic so that users who have it and overwritepackage.json.namein the project add the value set todevtoolNamespaceIn addition, the vscode engine has been updated to the latest version, and some dependencies have also been updated (
@vscode/debugadapter, @vscode/vsce and @vscode/debugprotocol).All tested on ios and android for ts and vue3 projects.
Close: #296 #293 #286 #280