Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 1.8 support #3

Merged
merged 1 commit into from Jun 17, 2012
Merged

Add Ruby 1.8 support #3

merged 1 commit into from Jun 17, 2012

Conversation

beccasaurus
Copy link

Small tweak to fix Ruby 1.8 compatibility (using Ruby 1.9's default block arguments breaks support for Ruby 1.8)

Using Ruby 1.9's default block arguments breaks support for Ruby 1.8.
natritmeyer added a commit that referenced this pull request Jun 17, 2012
@natritmeyer natritmeyer merged commit 80c5917 into natritmeyer:master Jun 17, 2012
@natritmeyer
Copy link
Owner

Just released v1.1.1 to add ruby 1.8 support. Thanks!

@natritmeyer
Copy link
Owner

Oh, and say Hi to @nathanbain for me :)

@beccasaurus
Copy link
Author

Will do :)

Thanks for the quick fix! You merged before I even got around to updating my other project's Gemfile to point to my fork (for the 1.8 support).

Also, thanks for taking a look-see at other branches and merging what looked good. Feel free to ignore my branches as well tho. If/when I think something's worthwhile and all specs pass/etc, I'll shoot a pull request your way!

Digging using site_prism so far (for some whitebox developer RSpec/Capybara acceptance specs) 😃

@natritmeyer
Copy link
Owner

Haha. It's 3:30am here and I can't sleep. Not much else to do than merge a pull request :)

I liked the fix to the #all_there? method, but I'm keeping the js methods in SitePrism::Section. Same with the title finder - the version you've got won't play nice if the page has no title - it'll wait for the title to appear and then when it doesn't it'll fall over.

Also, I just saw: https://github.com/remi/site_prism/commit/618d90d75efab2e865e7d68c3cddc23fd2edaf13#commitcomment-1467210 I have a deep respect for rails' use of #method_missing, but I can't stand it in my code. It's massively overused by noob rubyists and has been a cause of headaches I've had to fix before. Too many people have tied themselves in knots with it so I'll avoid it where I can :) See: http://martinfowler.com/articles/rubyAtThoughtWorks/metaprogramming.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants