-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSONP support for monitoring routes #103
Conversation
Also, the response content-type for jsonp is |
Damn finally... |
// ResponseHandler handles responses for monitoring routes | ||
func ResponseHandler(w http.ResponseWriter, r *http.Request, data []byte) { | ||
// Get callback from request | ||
callback := r.FormValue("callback") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably better off just using r.URL.Query().Get("callback")
as you only need to check the URL query params
@pkieltyka : done, thank you 😄 |
If not done already could someone update README to reflect the JSONP functionality? |
@derekcollison : What kind of information you want to see in README related to this PR? P.S.: Personally I'm thinking that |
The README has a monitoring section, just add a one liner that says it On Tue, Aug 18, 2015 at 5:29 PM, Fatih Cetinkaya notifications@github.com
|
This good to go? |
I just added a note to README about JSONP. I think it is okay to go... |
Add JSONP support for monitoring routes
See #100