jsonp support for monitoring routes?

[devfacet]

@derekcollison : Would you mind if I add JSONP support to monitoring routes and make a PR? That would help me to improve the tool that I'm working on... I didn't want to waste time if you are not okay with it.

Update: Note that I want to put more stuff to client side but can't do it due to CORS. That's the reason for JSONP.

[derekcollison]

Just to /routez?

On Wed, Aug 12, 2015 at 5:15 PM -0700, "Fatih Cetinkaya" notifications@github.com wrote:

@derekcollison : Would you mind if I add jsonp support to monitoring routes and make a PR? That would help me to improve the tool that I'm working on... I didn't want to waste time if you are not okay with it.

—
Reply to this email directly or view it on GitHub.

[devfacet]

All routes; /varz, /connz, /routez and /subscriptionsz

[derekcollison]

Send a PR, sounds fine to me.. What application is this for?

On Wed, Aug 12, 2015 at 6:51 PM, Fatih Cetinkaya notifications@github.com
wrote:

All routes; /varz, /connz, /routez and /subscriptionsz

—
Reply to this email directly or view it on GitHub
#100 (comment).

[devfacet]

Cool, will send a PR in a few days. It is for the tool that I'm working on. https://github.com/cmfatih/natsboard

[repejota]

+1

That would help a lot also on another monitor I'm working on.

[derekcollison]

Nice!

On Wed, Aug 12, 2015 at 9:39 PM, Fatih Cetinkaya notifications@github.com
wrote:

Cool, will send a PR in a few days. It is for the tool that I'm working
on. https://github.com/cmfatih/natsboard

—
Reply to this email directly or view it on GitHub
#100 (comment).

[pkieltyka]

Have a look at https://github.com/pressly/gohttpware/tree/master/jsonp for a Jsonp middleware that stays out of the way and is triggered by the content type. It's my code, feel free to copy / augment if it helps

[devfacet]

@pkieltyka : It would be awesome if you take over this task and deliver since you have already experience with it. What you say? :)

[pkieltyka]

Sure, no prob. I'll submit PR tomm

On Aug 13, 2015, at 8:47 PM, Fatih Cetinkaya notifications@github.com wrote:

@pkieltyka : It would be awesome if you take over this task and deliver since you have already experience with it. What you say? :)

—
Reply to this email directly or view it on GitHub.

[devfacet]

Sound awesome to me 👍

[devfacet]

@pkieltyka : I just made a PR for it. It was more easier than I thought. Somehow I always hesitate about my golang skills :)

Can you check it and let me know whether I'm naif or not? https://github.com/nats-io/gnatsd/pull/103/files

I locally test it and it works for;

$.getJSON('http://localhost:8222/connz?callback=?', function(data) { console.log(data); });

or

$.ajax({
  url: 'http://localhost:8222/connz',
  dataType: 'jsonp',
  jsonpCallback: 'callback',
  success: function(data) {
    console.log(data);
  }
});