Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(opts): clarify --no_advertise #953

Closed
wants to merge 1 commit into from

Conversation

JensRantil
Copy link

This commit came out of [1] and [2]. Clarifies current behaviour much
better.

[1] #950 (comment)
[2] #952

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

/cc @nats-io/core

This commit came out of [1] and [2]. Clarifies current behaviour much
better.

[1] nats-io#950 (comment)
[2] nats-io#952
@kozlovic kozlovic self-assigned this Apr 16, 2019
@kozlovic
Copy link
Member

The no_advertise is really for a server to not advertise its client host:port to the clients. That is, if a server is configured with no_advertise, it won't send to clients connecting to it information regarding other servers client host:port in the cluster (but also not communicate its to its members).
So yes, technically a server's own client host:port info is not sent to the members of the clusters, but really the key point is that it is not sending info to its clients.
Is that how you understood it and still think that the addition of cluster members is important?

@wallyqs
Copy link
Member

wallyqs commented Apr 17, 2019

@JensRantil apologies that may have contributed to the confusion 😕, when setting no_advertise cluster members are still advertised to other cluster peers so we can actually close this issue since change not needed (updated related issue as well #952 (comment))

@wallyqs
Copy link
Member

wallyqs commented Apr 28, 2019

Closing since no_advertise does advertise to cluster members and can be used to disable advertising to clients only.

@wallyqs wallyqs closed this Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants