Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a field to the user JWT that disables nonce verification when set. #62

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

aricart
Copy link
Member

@aricart aricart commented Dec 17, 2019

This field will be referenced by the server to allow it to decide whether to ignore nonce signatures.

@coveralls
Copy link

coveralls commented Dec 17, 2019

Pull Request Test Coverage Report for Build 316

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 88.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
user_claims.go 1 4 25.0%
Totals Coverage Status
Change from base Build 299: -0.2%
Covered Lines: 1063
Relevant Lines: 1196

💛 - Coveralls

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM... need to check with Derek if we want this or not..

@derekcollison
Copy link
Member

I don't see that change, just travis and staticcheck stuff.

However, for this, I don't think the JWT can make that determination, its a policy thing and one that the servers have to enforce IMO.

@aricart
Copy link
Member Author

aricart commented Jan 9, 2020

I don't see that change, just travis and staticcheck stuff.

However, for this, I don't think the JWT can make that determination, its a policy thing and one that the servers have to enforce IMO.

Yes the server has to enforce.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 0b6d1dc into master Jan 14, 2020
@aricart aricart deleted the bearer-token branch January 14, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants