changes to service/micro framework #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed `api_url` use `metadata` - removed `SCHEMA` verb, schemas can be reported via the endpoint metadata - added `metadata` on the endpoints report (was missing from the ADR)
ripienaar
requested changes
May 17, 2023
adr/ADR-32.md
Outdated
| - `endpoint` - an optional base endpoint configuration, consisting of valid NATS subject, | ||
| handler and optional request/response schema. The `name` of the base endpoint | ||
| should be set to `default` by the client libraries. | ||
| - `endpoint` - an optional base endpoint configuration, consisting of valid NATS |
There was a problem hiding this comment.
Nope - I already took it out.
adr/ADR-32.md
Outdated
| handler and optional request/response schema. The `name` of the base endpoint | ||
| should be set to `default` by the client libraries. | ||
| - `endpoint` - an optional base endpoint configuration, consisting of valid NATS | ||
| subject, handler and optional request/response schema. The `name` of the base |
There was a problem hiding this comment.
still mentions schema here
There was a problem hiding this comment.
the word schema is about the schema for the PING response fields - let me remove that
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api_urlusemetadataSCHEMAverb, schemas can be reported via the endpoint metadatametadataon the endpoints report (was missing from the ADR)