service changes #514
Merged
service changes #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponses [FIX] [SRV] cross-client test to print a context when generating an error [CHANGE] [SRV] removed `apiURL` config option and `api_url` report from schema - use `metadata`
…sponses [FIX] [SRV] cross-client test to print a context when generating an error [CHANGE] [SRV] removed `apiURL` config option and `api_url` - use `metadata` on the service [CHANGE] [SRV] removed schema reporting, configuration, and related types - use `metadata` on the endpoint
…sponses [FIX] [SRV] cross-client test to print a context when generating an error [CHANGE] [SRV] removed `apiURL` config option and `api_url` - use `metadata` on the service [CHANGE] [SRV] removed schema reporting, configuration, and related types - use `metadata` on the endpoint [DOC] updated the doc and examples for service
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to match ADR - nats-io/nats-architecture-and-design#219
Note that the ADR is not prescribing whether endpoints are added on the config, but feedback is that it is confusing to have one that is via configuration, so best just to simplify the UX of API by removing alternative mechanisms
[FIX] [SRV]
metadatanot included instats,schemaorpingresponses[FIX] [SRV] cross-client test to print a context when generating an error
[CHANGE] [SRV] removed
apiURLconfig option andapi_url- usemetadataon the service[CHANGE] [SRV] removed schema reporting, configuration, and related types - use
metadataon the endpoint[DOC] updated the doc and examples for service
[CHANGE] [SRV] removed endpoint configuration from service config - use
addEndpoint().