Add keys with filters #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
This was referenced Jun 20, 2024
ripienaar
reviewed
Jun 20, 2024
| // KeysWithFilter returns a filtered list of keys in the bucket. | ||
| // Historically this method returned a complete slice of all keys in the bucket, | ||
| // however clients should return interable result. | ||
| KeysWithFilter(filter string) ([]string, error) |
There was a problem hiding this comment.
I am really against all these extra methods. Especially against adding both WithFilter and WithFilters versions of these methods, it's not needed at all.
Would be worth adding a watchopt like FilterKeys(keys ...string) (for go as this is go here), Keys() already take watchops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek tomasz@nats.io