Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race conditions in gnatsd #3

Closed
klobucar opened this issue Jun 11, 2013 · 1 comment
Closed

Race conditions in gnatsd #3

klobucar opened this issue Jun 11, 2013 · 1 comment
Assignees

Comments

@klobucar
Copy link
Contributor

The race profiler found the following race conditions in the gist below.

go test -race ./... is the command I used to generate the output.

https://gist.github.com/klobucar/88b534fa2749a8ae8bc6

@ghost ghost assigned derekcollison Jun 11, 2013
@derekcollison
Copy link
Member

This is clean.

gaozhidf pushed a commit to ericsson-ddi/gnatsd that referenced this issue Nov 2, 2016
derekcollison added a commit that referenced this issue Aug 3, 2023
This PR backports the OCSP Peer feature option (as in 2.10 train) and
includes two fixes for the existing OCSP Staple feature.

OCSP Staple: 

1. Fixed and clarified how NATS Server determines its own Issuer CA when
obtaining and validating an OCSP Response for subsequent staple
2. Eliminated problematic assumption that all node peers are issued by
same CA when NATS Server validates ROUTE and GATEWAY peer nodes
3. Added OCSP Response effectivity checks on ROUTE and GATEWAY
peer-presented staple

Note for #3: Allowed host clock skew between node peers set at
30-seconds. If the OCSP Response contains an empty assertion for
NextUpdate, NATS Server will default to 1-hour validity (after
ThisUpdate). It is recommended that CA OCSP Responder should assert
NextUpdate.
levb referenced this issue in levb/nats-server Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants