Fixed loss of queue subscription interest across Gateways in some cases #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose two servers, SA in cluster A and SB in cluster B. If SA sends a message to SB on an account for which there is no interest at all (account not known or no subscription), SB will send an A- and keep track that it sent an A- for this account. When a queue subscription is created on SB, SB will send and RS+ to A because A needs to have perfect knowledge of all queue subs in all clusters. If then a regular subscription is also created on SB, SB will think that it needs to send an A+ because it had sent an A- for this account. However, SA had an entry for this account for the queue sub. The A+ would clear the entry in the map and would cause SA to not send messages to SB even if they would have been a match for the queue sub on SB. We fix this in two ways: - Clear the possible A- in SB when sending an RS+ for queue sub - Processing of A-/A+ to be aware of a possible entry in the map due to queue subs. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
fix_gw_qinterest_loss
branch
from
c82e6f5
to
b325cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose two servers, SA in cluster A and SB in cluster B. If SA
sends a message to SB on an account for which there is no interest
at all (account not known or no subscription), SB will send an A-
and keep track that it sent an A- for this account.
When a queue subscription is created on SB, SB will send and RS+
to A because A needs to have perfect knowledge of all queue subs
in all clusters.
If then a regular subscription is also created on SB, SB will
think that it needs to send an A+ because it had sent an A- for
this account. However, SA had an entry for this account for the
queue sub. The A+ would clear the entry in the map and would cause
SA to not send messages to SB even if they would have been a
match for the queue sub on SB.
We fix this in two ways:
due to queue subs.
Signed-off-by: Ivan Kozlovic ivan@synadia.com