Fix flappers #1014
Merged
Fix flappers #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TestSystemAccountConnectionUpdatesStopAfterNoLocal: I believe that the check on number of notifications was wrong. Since we did not consume the ones for the connect, the expected count after the disconnect is 8 instead of 4. - Possible fix GW tests complaining about number of outbound/inbound I think that it may be possible that connection does not succeed right away (remote to fully started, etc) and due to dial timeout and reconnect attempt delay, I suspect that when given a max time of 1sec to complete, it may not be enough. Quick change for now is to override to 2secs for now in the wait helpers. If that proves conclusive, we could remove the timeout given to these helpers. - TestGatewaySendAllSubsBadProtocol: used a t.Fatalf() in checkFor instead of return fmt.Errorf(). - TestLeafNodeResetsMSGProto: this test is not about change to interest mode only, so to avoid possible mix of protos, delay a bit creation of gateway after creation of leaf node. - Some defer s.Shutdown() were missing Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSystemAccountConnectionUpdatesStopAfterNoLocal: I believe that
the check on number of notifications was wrong. Since we did not
consume the ones for the connect, the expected count after the
disconnect is 8 instead of 4.
Possible fix GW tests complaining about number of outbound/inbound
I think that it may be possible that connection does not succeed
right away (remote to fully started, etc) and due to dial timeout
and reconnect attempt delay, I suspect that when given a max time
of 1sec to complete, it may not be enough.
Quick change for now is to override to 2secs for now in the
wait helpers. If that proves conclusive, we could remove the
timeout given to these helpers.
TestGatewaySendAllSubsBadProtocol: used a t.Fatalf() in checkFor
instead of return fmt.Errorf().
TestLeafNodeResetsMSGProto: this test is not about change to
interest mode only, so to avoid possible mix of protos, delay
a bit creation of gateway after creation of leaf node.
Some defer s.Shutdown() were missing
Signed-off-by: Ivan Kozlovic ivan@synadia.com