Update to connect/reconnect error reports logic #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the introduced new option and added a new one. The idea is to be able to differentiate between never connected and reconnected event. The never connected situation will be logged at first attempt and every hour (by default, configurable). However, once connected and if trying to reconnect, will report every attempts by default, but this is configurable too. These two options are supported for config reload. Related to #1000 Related to #1001 Resolves #969 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison I want to emphasize that this PR is changing the name of an option and a public constant that were introduced in PR #1001 and made it to RC-14. I think it is worth not burden ourselves with deprecation/backward compatibility with that if we thing that this PR behavior is better, but I wanted you to be fully aware of that. I won't merge until you have a chance to possibly revisit. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the introduced new option and added a new one. The idea
is to be able to differentiate between never connected and reconnected
event. The never connected situation will be logged at first attempt
and every hour (by default, configurable).
However, once connected and if trying to reconnect, will report every
attempts by default, but this is configurable too.
These two options are supported for config reload.
Related to #1000
Related to #1001
Resolves #969
Signed-off-by: Ivan Kozlovic ivan@synadia.com