Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leafnode updates #1049

Merged
merged 3 commits into from Jul 1, 2019
Merged

Leafnode updates #1049

merged 3 commits into from Jul 1, 2019

Conversation

derekcollison
Copy link
Member

Added a default port so you can make simpler configs to connect to remote clusters like NGS.
Connect was incorrectly a Noticef, where all other connection types this is a Debugf, fixed.
Did add a Noticef on first connect though to avoid need for -DV to know connection worked.

/cc @nats-io/core

Signed-off-by: Derek Collison <derek@nats.io>
…Noticef.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not change r.URL.Host directly but instead re-create r.URL..

server/opts.go Outdated Show resolved Hide resolved
Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 769f9e4 into master Jul 1, 2019
@derekcollison derekcollison deleted the lndp branch July 1, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants