support sampling time to ack messages in explicit ack mode #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
commented
Dec 17, 2019
|
ripienaar
force-pushed
the
ack_sampling
branch
from
45d0dea
to
9161a28
Compare
ripienaar
commented
Dec 17, 2019
server/msgset.go
Outdated
| @@ -113,7 +113,7 @@ func (a *Account) AddMsgSet(config *MsgSetConfig) (*MsgSet, error) { | |||
| } | |||
| // Setup the internal client. | |||
| c := s.createInternalJetStreamClient() | |||
| mset := &MsgSet{jsa: jsa, config: cfg, client: c, obs: make(map[string]*Observable)} | |||
| mset := &MsgSet{jsa: jsa, config: cfg, client: c, obs: make(map[string]*Observable), mu: sync.RWMutex{}} | |||
There was a problem hiding this comment.
seems unlikely that this would be needed but I triggered this without it
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1439c7e]
goroutine 934 [running]:
github.com/nats-io/nats-server/v2/server.(*MsgSet).Name(0x0, 0x0, 0x0)
/Users/rip/go/src/github.com/nats-io/nats-server/server/msgset.go:432 +0x2e
github.com/nats-io/nats-server/v2/server.(*Observable).sampleAck(0xc0000ab6c0, 0x1, 0x1)
/Users/rip/go/src/github.com/nats-io/nats-server/server/observable.go:540 +0x68
github.com/nats-io/nats-server/v2/server.(*Observable).ackMsg(0xc0000ab6c0, 0x1, 0x1)
/Users/rip/go/src/github.com/nats-io/nats-server/server/observable.go:561 +0x1a3
There was a problem hiding this comment.
Yea we should not need it, will fix elsewhere.
There was a problem hiding this comment.
ah thats true, you're right it is the msgset, that really shouldnt happen :)
ripienaar
force-pushed
the
ack_sampling
branch
from
24b0cd3
to
a713543
Compare
|
after latest commits we have: |
ripienaar
force-pushed
the
ack_sampling
branch
from
1702b1f
to
b9dcdb7
Compare
|
I think we could be more consistent with naming. Some ideas below. |
This allows an observable to have a sampling frequency and will publish ack times regularly
ripienaar
force-pushed
the
ack_sampling
branch
from
c6efaaf
to
2ef4677
Compare
|
updated key names and rebased onto latest jetstream branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick spike on the idea I mentioned of sampling ack times in observables