Fix for #1344 #1345
Merged
Fix for #1344 #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Apr 14, 2020
| // This will be a prefix so add on the wildcard. | ||
| if siReply != nil { | ||
| wcsub := append(siReply, '>') | ||
| c.leaf.smap[string(wcsub)]++ |
There was a problem hiding this comment.
What about if any server in the super-cluster is restarted (same issue that when we need to know that any node in the super-cluster starts so that we switch GW to interest-only mode for leafnode accounts)?
There was a problem hiding this comment.
Could take a closer look. Since the code in question that dealt with the siReply on the fly dealt with routes, GWs and LNs.
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account had a pre-existing siReply wildcard and a leafnode restarted this subscription was not being properly sent to the new leafnode connection.
Signed-off-by: Derek Collison derek@nats.io
Resolves #1344
/cc nats-io/core