[FIXED] Handling of gossiped URLs #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some servers in the cluster have the same connect URLs (due to the use of client advertise), then it would be possible to have a server sends the connect_urls INFO update to clients with missing URLs. Resolves #1515 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
matthiashanel
approved these changes
Jul 16, 2020
server/server.go
Outdated
| @@ -97,6 +97,8 @@ type Info struct { | |||
| LeafNodeURLs []string `json:"leafnode_urls,omitempty"` // LeafNode URLs that the server can reconnect to. | |||
| } | |||
|
|
|||
| type gossipURLs map[string]int | |||
There was a problem hiding this comment.
maybe move to util where it's functions are?
There was a problem hiding this comment.
I wonder even if I make that a type. It does not prevent one from using map[string]int directly anyway. But if I keep as a type, should I name it differently? Should it be more mapOfURLsWithRefcount or something like that? (I am very bad at naming)
There was a problem hiding this comment.
I'm fine with the current name. Maybe refCountedUrlSet?
There was a problem hiding this comment.
I have renamed, moved to util and made the add/remove/get receivers for this new type. I think it is cleaner. I you could have another look, I would appreciate it.
Also made the add/remove/getAsStringSlice receiver for this type. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some servers in the cluster have the same connect URLs (due
to the use of client advertise), then it would be possible to
have a server sends the connect_urls INFO update to clients with
missing URLs.
Resolves #1515
Signed-off-by: Ivan Kozlovic ivan@synadia.com