Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] LeafNode reject duplicate remote #1738

Merged
merged 1 commit into from
Nov 24, 2020
Merged

[FIXED] LeafNode reject duplicate remote #1738

merged 1 commit into from
Nov 24, 2020

Commits on Nov 23, 2020

  1. [FIXED] LeafNode reject duplicate remote

    There was a test to prevent an errorneous loop detection when a
    remote would reconnect (due to a stale connection) while the accepting
    side did not detect the bad connection yet.
    
    However, this test was racy because the test was done prior to add
    the connections to the map.
    
    In the case of a misconfiguration where the remote creates 2 different
    remote connections that end-up binding to the same account in the
    accepting side, then it was possible that this would not be detected.
    And when it was, the remote side would be unaware since the disconnect/
    reconnect attempts would not show up if not running in debug mode.
    
    This change makes sure that the detection is no longer racy and returns
    an error to the remote so at least the log/console of the remote will
    show the "duplicate connection" error messages.
    
    Resolves #1730
    
    Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    kozlovic committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    f155c75 View commit details
    Browse the repository at this point in the history