[Added] account name checks for leaf nodes in operator mode #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules out implausible ones. Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
requested changes
Nov 23, 2020
server/server.go
Outdated
| @@ -451,6 +451,18 @@ func NewServer(opts *Options) (*Server, error) { | |||
| return nil, fmt.Errorf("no local account %q for remote leafnode", r.LocalAccount) | |||
| } | |||
| } | |||
| } else { | |||
| if len(opts.LeafNode.Users) != 0 { | |||
There was a problem hiding this comment.
Would that be possible to move those checks in validateLeafNode() which checks for options?
There was a problem hiding this comment.
absolutely, I placed them here because of the non operator mode checks. Ok to move all those checks?
There was a problem hiding this comment.
That being said, I am not sure since we call this in NewServer()
if err := validateOptions(opts); err != nil {
return nil, err
}
but before we actually process the trusted keys:
// Trusted root operator keys.
if !s.processTrustedKeys() {
return nil, fmt.Errorf("Error processing trusted operator keys")
}
would have to make sure that the validation of leafnode would still work if you move them there.
Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
requested changes
Nov 24, 2020
Signed-off-by: Matthias Hanel <mh@synadia.com>
Signed-off-by: Matthias Hanel <mh@synadia.com>
This was referenced Mar 15, 2021
Closed
Merged
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules out implausible ones
Signed-off-by: Matthias Hanel mh@synadia.com