Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] support for tags and filter ping monitoring requests by tags #1832

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

matthiashanel
Copy link
Contributor

@matthiashanel matthiashanel commented Jan 22, 2021

fixes #1588

Signed-off-by: Matthias Hanel mh@synadia.com

original issue asks for map, but I'd rather stick to the same label format we have in other places.
For now I also refrained from sending them between server.

fixes #1588

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move Tags in the server.Options struct and add a comment to it.

server/opts.go Outdated Show resolved Hide resolved
Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tag map to the server configuration
2 participants