Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Allow bearer token as mqtt authentication method #1840

Merged
merged 2 commits into from Jan 26, 2021
Merged

[ADDED] Allow bearer token as mqtt authentication method #1840

merged 2 commits into from Jan 26, 2021

Conversation

angiglesias
Copy link
Contributor

Changes proposed in this pull request:

  • Allow parsing password field on MQTT Connect request as a JWT to use bearer token client authentication/authorization

Tests added

  • Test MQTT authentication with tokens with different "allowed connection types" to ensure correct user authorization

/cc @nats-io/core

@angiglesias
Allow use MQTT Connection password field as a JWT to authenticate cli…
4fd58ef 
…ents

Signed-off-by: Ángel <angelo.fly1@gmail.com>
@angiglesias angiglesias changed the title [ADDED] Allow bearer token as mqtt authentication [ADDED] Allow bearer token as mqtt authentication method Jan 25, 2021
@angiglesias angiglesias marked this pull request as ready for review January 25, 2021 17:41
@angiglesias
Added tests for MQTT bearer token authentication
07c3214 
Signed-off-by: Ángel <angelo.fly1@gmail.com>
@kozlovic
Copy link
Member

@angiglesias Thank you for your contribution! I was planning on doing just that, so thanks! I will have a look later today.

kozlovic
kozlovic approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! This approach will allow user to use MQTT clients with NATS operator mode.

@kozlovic kozlovic merged commit 0fe9209 into nats-io:master Jan 26, 2021
This was referenced Mar 15, 2021
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angiglesias @kozlovic