Fix for #2011 and atomics on 32bit systems. #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
philpennock
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Do we have stats (from CI on this PR?) on any performance impact from moving the mutex away from the zero-offset and how that changes addressing modes used in the generated code?
I think the mutex is always 24 octets wide, so IF there is a performance regression, that could be moved back to the front. But I don't know that there is any performance impact.
|
We have the mutex moved already for the client struct which is our most sensitive to perf so I think we are good. But I do not have direct numbers of impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core