When a stream is a mirror or has sources we need to check the upstream streams. #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Mar 17, 2021
…m streams for filter subject correctness. Signed-off-by: Derek Collison <derek@nats.io>
wallyqs
reviewed
Mar 17, 2021
| hasExt = true | ||
| break | ||
| } | ||
| subjects = append(subjects, acc.streamSourceSubjects(si)...) |
There was a problem hiding this comment.
In case we have stream that it itself is sourced from another stream like:
Stream M1 <- OriginA
Stream M2 <- OriginB
Stream S1 <- M1, M2
Then it will fail to match since we need to check against the subjects from either OriginA or OriginB.
There was a problem hiding this comment.
Good point, need to make it recursive it seems to some degree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core