Fix for #1976 #2053
Merged
Fix for #1976 #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Mar 31, 2021
| @@ -2351,7 +2352,7 @@ func (s *Server) jsMsgGetRequest(sub *subscription, c *client, subject, reply st | |||
|
|
|||
| subj, hdr, msg, ts, err := mset.store.LoadMsg(req.Seq) | |||
| if err != nil { | |||
| resp.Error = jsError(err) | |||
| resp.Error = jsNoMessageFoundErr | |||
There was a problem hiding this comment.
not sure, i mean LoadMsg can fail for many reasons, perhaps LoadMsg should return a specific error for not found vs other kinds of failure - if it can detect it, then we can have 404 and 500 appropriately?
There was a problem hiding this comment.
Most of the others are captured above. This is what we do for a pull consumer also, essentially turn everything into a not found error.
There was a problem hiding this comment.
Ok. Consistency matters most then. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core