Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] #2242. #2245

Merged
merged 2 commits into from May 24, 2021
Merged

[FIXED] #2242. #2245

merged 2 commits into from May 24, 2021

Conversation

derekcollison
Copy link
Member

When we had a duplicate detected in R>1 mode we set the skip sequence indicator but were not using that when dealing with underlying store.

Resolves: #2242

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

@derekcollison
Fix for #2242.
308355a 
When we had a duplicate detected in R>1 mode we set the skip sequence indicator but were not using that when dealing with underlying store.

Signed-off-by: Derek Collison <derek@nats.io>
ripienaar
ripienaar approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kozlovic
kozlovic approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a conflict, likely from the merge of previous PR that need to be addressed.

kozlovic
kozlovic approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 11539ec into master May 24, 2021
@derekcollison derekcollison deleted the msgid branch May 24, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expected sequence does not match store when using Nats-Msg-Id header
3 participants
@derekcollison @ripienaar @kozlovic