Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external dependency on 'ps' for memory and cpu usage. #2260

Merged
merged 1 commit into from Jun 7, 2021

Conversation

derekcollison
Copy link
Member

This removes the dependency on ps and just uses rusage and sampling for percentage of cpu. We do not use virtual memory size in any of the upper layers.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 3ab2a1e into master Jun 7, 2021
@derekcollison derekcollison deleted the remove_ps_macosx branch June 7, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants