Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Headers were lost from a response across a GW and through a route. #2278

Merged
merged 1 commit into from Jun 10, 2021

Conversation

derekcollison
Copy link
Member

When receiving a response across a gateway that has headers and a globally routed subject (GR) we were dropping header information.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

server/gateway.go Outdated Show resolved Hide resolved
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for addition of const that is no longer needed.

server/client.go Outdated Show resolved Hide resolved
…bally routed subject (_GR_) we were dropping header information.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit afbb8bf into master Jun 10, 2021
@derekcollison derekcollison deleted the gr_hdrs branch June 10, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants