New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] #2401 #2410
[FIXED] #2401 #2410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but not sure if info.Domain empty should be treated differently.
lnc := c.createLeafNodesWithTemplateAndStartPort(tmpl, "SPOKE", 3, 11311) | ||
defer lnc.shutdown() | ||
|
||
//lncm := c.createLeafNodesWithTemplateMixedMode(tmpl, "SPOKE", 3, 2, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes will update.
@@ -1057,7 +1058,7 @@ func (c *client) processLeafnodeInfo(info *Info) { | |||
c.Debugf("Error adding JetStream domain mapping: %v", err) | |||
} | |||
} | |||
} else if hasJSDomain { | |||
} else if hasJSDomain && opts.JetStreamDomain != info.Domain { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to treat info.Domain
possibly empty (old server?) differently here or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No for this one we want both empty or exact match.
Leafnodes with same domain and shared system account should behave like flat jetstream network.
Signed-off-by: Derek Collison derek@nats.io
Resolves #2401
/cc @nats-io/core