New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign default to MaxAckPending when AckExplicit -or- AckAll #2428

Merged

derekcollison merged 1 commit into main from defaulting_max_ack_pending

Aug 10, 2021

Contributor

scottf commented Aug 10, 2021

Tests added
Branch rebased on top of current main (git pull --rebase origin main)
Changes squashed to a single commit (described here)
Build is green in Travis CI
You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Explicitly sets MaxAckPending when not supplied to AckExplicit or AckAll, not just AckExplicit

/cc @nats-io/core


          assign default to MaxAckPending when AckExplicit -or- AckAll, not jus…

84d37e8

…t AckExplicit

scottf requested a review from derekcollison

August 10, 2021 21:42

derekcollison approved these changes

View reviewed changes

Member

derekcollison left a comment

LGTM

derekcollison merged commit cf23e8e into main

derekcollison deleted the defaulting_max_ack_pending branch

August 10, 2021 23:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment