fix daisy chained leaf node subject propagation issue. #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shows issue #2448 Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
changed the title
Signed-off-by: Matthias Hanel <mh@synadia.com>
…SendSubs Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
changed the title
derekcollison
approved these changes
Aug 25, 2021
server/sublist.go
Outdated
| if sub != nil && sub.client != nil && | ||
| (sub.client.kind == CLIENT || sub.client.kind == SYSTEM || sub.client.kind == JETSTREAM || sub.client.kind == ACCOUNT) && sub.im == nil { | ||
| (sub.client.kind == CLIENT || sub.client.kind == LEAF || sub.client.kind == SYSTEM || sub.client.kind == JETSTREAM || sub.client.kind == ACCOUNT) && sub.im == nil { | ||
| if sub.client.isSpokeLeafNode() { |
There was a problem hiding this comment.
Could add this above to conditional.
if (kind == LEAF && client.isSpokeLeafNode()) || ...
There was a problem hiding this comment.
the isSpokeLeafNode checks for LEAF as well. so figured I don't keep the redundancy. but will add comment
Signed-off-by: Matthias Hanel <mh@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shows issue #2448 and possible fix locations
Signed-off-by: Matthias Hanel mh@synadia.com