Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Websocket: possible panic when decoding CLOSE frame #2519

Merged
merged 2 commits into from Sep 13, 2021
Merged

Conversation

kozlovic
Copy link
Member

Resolves #2510

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Resolves #2510

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Same comment as Go client.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic
Copy link
Member Author

@derekcollison I have applied the same changes than in the Go client. Let me know if you want to review or if it is ok to merge.

@kozlovic kozlovic merged commit 6e705c2 into main Sep 13, 2021
@kozlovic kozlovic deleted the fix_2510 branch September 13, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server websocket.go crash
2 participants