[FIXED] #2525 #2526
Merged
[FIXED] #2525 #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to error if we exceed that limit. Signed-off-by: Derek Collison <derek@nats.io>
ripienaar
reviewed
Sep 14, 2021
| // Since we encode header len as u16 make sure we do not exceed. | ||
| // Again this works if it goes through but better to be pre-emptive. | ||
| if len(hdr) > math.MaxUint16 { | ||
| err := fmt.Errorf("JetStream header size exceeds limits for '%s > %s'", jsa.acc().Name, mset.cfg.Name) |
There was a problem hiding this comment.
on the assumption someone might be trying to trigger overflows or memory exchaustion attacks should we maybe log the IP of the client or some info about him?
Otherwise LGTM
There was a problem hiding this comment.
If the message violates total payload limits or control line limits the error is logged and the client cutoff.
There was a problem hiding this comment.
Yes, but I am mainly interested in having a way to know who is the bad client - i guess events will be raised so its probably fine. LGTM..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use u16 to encode header len when replicating JetStream messages.
Make sure to error if we exceed that limit.
Signed-off-by: Derek Collison derek@nats.io
Resolves #2525
/cc @nats-io/core