[CHANGED] JetStream: flow control requires heartbeats #2533
Conversation
The server will now reject the creation of a push consumer with flow control if no heartbeat is set. Resolves #2520 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Yes, which I followed: |
There was a problem hiding this comment.
Not directly related, but I'm just wondering if there is a minimum heartbeat that makes sense. Like a heartbeat every 100 ms seems like overkill, but maybe there is a use case for it. I mean getting a heartbeat every 100ms seems like a lot of unnecessary traffic, Maybe there should be a minimum?
| @@ -152,6 +152,9 @@ const ( | |||
| // JSConsumerWQRequiresExplicitAckErr workqueue stream requires explicit ack | |||
| JSConsumerWQRequiresExplicitAckErr ErrorIdentifier = 10098 | |||
|
|
|||
| // JSConsumerWithFlowControlNeedsHeartbeats consumer with flow control also needs heartbeats | |||
| JSConsumerWithFlowControlNeedsHeartbeats ErrorIdentifier = 10108 | |||
There was a problem hiding this comment.
Is there a scheme to error ids? Ask RI I suppose
|
Heartbeats also useful in some leader election scenarios, and, at least in tests, very short intervals help no real schema for constants just make them obvious |
|
Agree we should have a sane minimum. Default for directs for sources and mirrors is 2s, I think OrderedConsumer is 5s. I might offer 500ms as lowest, but maybe even 1s. |
The server will now reject the creation of a push consumer with
flow control if no heartbeat is set.
Resolves #2520
Signed-off-by: Ivan Kozlovic ivan@synadia.com