Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize filestore, bug fixes, test tweaks. #2545

Merged
merged 8 commits into from Sep 20, 2021
Merged

Stabilize filestore, bug fixes, test tweaks. #2545

merged 8 commits into from Sep 20, 2021

Conversation

derekcollison
Copy link
Member

See individual CLs.

Note coveralls still broke so that test on Travis always failing atm.

Signed-off-by: Derek Collison derek@nats.io

Resolves: #2544

/cc @nats-io/core

Signed-off-by: Derek Collison <derek@nats.io>
Also hold lock while doing sync and optionally close FDs if idle.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Was penalizing large non-dedupe streams on startup.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, dont know this code but been running the branch all morning and seems fine

…t msg id

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nats-server slice bounds out of range
3 participants