protect against negative dupe window via negative max age

[ripienaar]

Signed-off-by: R.I.Pienaar rip@devco.net

/cc @nats-io/core

[derekcollison]

LGTM

[ripienaar]

I considered doing this, which if we go this way would probably remove over 1KLOC of boiler plate, thoughts @derekcollison ?

(after the release though)

type testServer struct {
	s  *Server
	nc *nats.Conn
	js nats.JetStreamContext
}

func withBasicJetStreamServer(t *testing.T, f func(*testing.T, *testServer)) {
	t.Helper()

	s := RunBasicJetStreamServer()
	defer s.Shutdown()

	config := s.JetStreamConfig()
	if config != nil {
		defer removeDir(t, config.StoreDir)
	}

	nc, js := jsClientConnect(t, s)
	defer nc.Close()

	f(t, &testServer{s, nc, js})
}

func TestNegativeDupeWindow(t *testing.T) {
	withBasicJetStreamServer(t, func(t *testing.T, srv *testServer) {
		// we incorrectly set MaxAge to -1 which then as a side effect sets dupe window to -1 which should fail
		_, err := srv.js.AddStream(&nats.StreamConfig{
			Name:              "TEST",
			Subjects:          nil,
			Retention:         nats.WorkQueuePolicy,
			MaxConsumers:      1,
			MaxMsgs:           -1,
			MaxBytes:          -1,
			Discard:           nats.DiscardNew,
			MaxAge:            -1,
			MaxMsgsPerSubject: -1,
			MaxMsgSize:        -1,
			Storage:           nats.FileStorage,
			Replicas:          1,
			NoAck:             false,
		})
		if err == nil || err.Error() != "duplicates window can not be negative" {
			t.Fatalf("Expected dupe window error got: %v", err)
		}
	})
}

[derekcollison]

Great idea! Let's get 2.5.1 out but I like the approach.