Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] #2551 #2554

Merged
merged 1 commit into from Sep 21, 2021
Merged

[FIXED] #2551 #2554

merged 1 commit into from Sep 21, 2021

Conversation

derekcollison
Copy link
Member

When a mirror would be processed before the origin stream we would not recover the consumers due to failure on looking up source's subjects.

This change processes all streams first then does all consumers.

Signed-off-by: Derek Collison derek@nats.io

Resolves #2551

/cc @nats-io/core

When a mirror would be processed before the origin stream we would not recover the consumers due to failure on looking up source's subjects.
This change processes all streams first then does all consumers.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 29037a4 into main Sep 21, 2021
@derekcollison derekcollison deleted the issue-2551 branch September 21, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetStream: Invalid consumer filter subject on server restart in some cases
3 participants