[IMPROVED] Websocket: added client IP from X-Forwarded-For header #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for cases when there is a proxy (Nginx, HAProxy, etc..) between the client and the NATS Server. If this header is present, the first IP is the one of the originating client and will be used as the host/IP in server's representation of the client host. Resolves #2514 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
NAK: this needs to be reverted or improved. Sorry, I missed the original request to review. |
kozlovic
added a commit
that referenced
this pull request
Jan 3, 2022
Instead of replacing connection's host with value specified by this header, we will simply add the address to the logging only. So instead of having something like: ``` 192.168.1.1:5678 - wid:10 - Client connection created ``` we could have: ``` 1.2.3.4/192.168.1.1:5678 - wid:10 - Client connection created ``` As seen above, this PR simply prefixes the connection's remote address with the header's value (if a valid IP). Related to #2734 Resolves #2767 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for cases when there is a proxy (Nginx, HAProxy, etc..)
between the client and the NATS Server. If this header is present,
the first IP is the one of the originating client and will be
used as the host/IP in server's representation of the client host.
Resolves #2514
Signed-off-by: Ivan Kozlovic ivan@synadia.com