Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] JetStream: interest across gateways #2750

Merged
merged 1 commit into from Dec 20, 2021
Merged

[FIXED] JetStream: interest across gateways #2750

merged 1 commit into from Dec 20, 2021

Conversation

kozlovic
Copy link
Member

If the interest existed prior to the initial creation of the
consumer, the gateway "watcher" would not be started, which means
that interest moving across the super-cluster after that would
not be detected.

The watcher runs every second and not sure if this is costly or
not, so we may want to go a different approach of having a separate
interest change channel that would be specific to gateways. But this
means adding a new sublist where the interest would be registered
and that sublist would need to be updated when processing GW RSub
and RUnsub?

Resolves #2745

Signed-off-by: Ivan Kozlovic ivan@synadia.com

If the interest existed prior to the initial creation of the
consumer, the gateway "watcher" would not be started, which means
that interest moving across the super-cluster after that would
not be detected.

The watcher runs every second and not sure if this is costly or
not, so we may want to go a different approach of having a separate
interest change channel that would be specific to gateways. But this
means adding a new sublist where the interest would be registered
and that sublist would need to be updated when processing GW RSub
and RUnsub?

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 6810e48 into main Dec 20, 2021
@kozlovic kozlovic deleted the fix_2745 branch December 20, 2021 16:45
@tbeets
Copy link
Contributor

tbeets commented Dec 20, 2021

Could this scheme at a server be inverted (eval on SUB/UNSUB at the server) to solve the general case of alerting on foreign-account interest changes?

@tbeets
Copy link
Contributor

tbeets commented Dec 20, 2021

On SUB/UNSUB can we follow the current export/import maps in reverse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants