Detect exact duplicates for URLs for routes, gateways or leafnodes. #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wallyqs could you double check my warnings logic, not as familiar with that as you are. |
…, enter a warning and ignore. If misconfigured could prevent the JetStream system from electing a leader. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
dupe_urls_config
branch
from
0071a7e
to
e204a79
Compare
|
Thanks. Had a side effect that was making another test fail, so fixed that and want @wallyqs to eyeball the warning construction. |
wallyqs
reviewed
Mar 17, 2022
Co-authored-by: Waldemar Quevedo <wally@synadia.com>
wallyqs
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
LGTM.
Currently it reads like this:
examples/js-cluster.conf:9:6: invalid use of field "nats://127.0.0.1:6224": Duplicate route entry detected
examples/js-cluster.conf:11:6: invalid use of field "nats://127.0.0.1:6225": Duplicate route entry detected
The lines already point to the location so that is enough I think, but we could make the warning clearer by changing the field from the warning error so that it reads something like this:
examples/js-cluster.conf:9:6: invalid use of field "routes": Duplicate route "nats://127.0.0.1:6224" entry detected
examples/js-cluster.conf:11:6: invalid use of field "routes": Duplicate route "nats://127.0.0.1:6225" entry detected
Have a commit here with the change showing how it could look like: c7e357e
|
I committed your suggestion already, maybe pull and see? lmk |
|
Actually will merge and we can iterate on warning as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If misconfigured could prevent the JetStream system from electing a leader. We will skip the entry and warn to the log.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core