[ADDED] Logs to healthcheck handler #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/monitor.go
Outdated
| @@ -2768,6 +2768,7 @@ func (s *Server) HandleHealthz(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| hs := s.healthz() | |||
| if hs.Error != _EMPTY_ { | |||
| s.Errorf("Healthcheck failed: %q", hs.Error) | |||
There was a problem hiding this comment.
Might suggest this be a Warnf since it can and should clear.
Kubernetes probes don't use nor log the reponse body of health endpoints. This means that for some reason a nats node running in Kubernetes becomes on a Not Ready state we won't have a way to know why other than to manually access the cluster and call the /healthz endpoint manually and see the error. This change adds an error log so we can observe what is going wrong with a nats node that is not ready. Signed-off-by: Samuel Torres <samuel.torres@form3.tech>
|
Agree that it would be helpful - looks like Kubelet may log the response body with |
kozlovic
approved these changes
Mar 30, 2022
kozlovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes probes don't use nor log the reponse body of health
endpoints. This means that for some reason a nats node running in
Kubernetes becomes on a Not Ready state we won't have a way to know why
other than to manually access the cluster and call the /healthz endpoint
manually and see the error.
This change adds an error log so we can observe what is going wrong with
a nats node that is not ready.
Signed-off-by: Samuel Torres samuel.torres@form3.tech
Resolves #NNNgit pull --rebase origin main)Resolves #
Changes proposed in this pull request:
/cc @nats-io/core