Fixes #2969, on reload stream import was not removed for js streams #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Hanel <mh@synadia.com>
|
ok will take a look in a few. |
…COUNT, etc) when reloading authorization, etc. We were also not copying over local state that has been added over the years to track different types of clients. We also needed to make sure to reuse the account's internal client and the subscription id (acc.isid). Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
issue-2969
branch
from
08efb58
to
5182154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still does not work, out of ideas.